[CALCITE-4841] Support decimal column type in CSV and File adapter

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.29.0
• Component/s: csv-adapter, file-adapter
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Louis Kuang
• Created: 08/Oct/21 15:41
• Updated: 04/Jan/22 08:27
• Resolved: 04/Jan/22 08:27

Description

Currently, the csv adapter does not support the decimal/numeric column type (see supported types in CsvFieldType. Any type that is not supported will be interpreted by the CsvEnumerator as string.

When dealing with decimal numbers, the currently most appropriate type is `double`. However, this is not accurate enough for financial data. This feature request proposes adding a `decimal` column type that will be implemented by the Java `BigDecimal` type (and by conversion in JavaToSqlTypeConversionRules be represented as a `Decimal` SQL type). This allow financial data to be represented and computed more accurately (`BigDecimal` has higher precision than `double`).

Please see sample implementation in PR.

Context: I am trying to leverage Calcite to add some SQL support to ledger reporting.

Issue Links

• links to: GitHub Pull Request #2572