[CALCITE-4834] JaninoRelMetadataProvider uses hardcoded class name

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.28.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Ruben Q L
• Reporter: Ruben Q L
• Created: 06/Oct/21 15:41
• Updated: 27/Feb/24 22:23
• Resolved: 06/Oct/21 18:44

Description

This seems caused by CALCITE-4546 (fbbdf46)

JaninoRelMetadataProvider lines 135 & 141 is using (for the generated code) the hardcoded name of the class MetadataDef:

buff.append("  private final org.apache.calcite.rel.metadata.MetadataDef def;\n");
for (Map.Entry<MetadataHandler<?>, String> handlerAndName : handlerToName.entrySet()) {
  ...
  .append("      org.apache.calcite.rel.metadata.MetadataDef def");

This can lead to issues (e.g. if a downstream project shades Calcite library). The safer way to do this is using Class#getName, as it is already done in the rest of the code, e.g. in JaninoRelMetadataProvider:158:

.append(MetadataDef.class.getName())

Issue Links

• is caused by: CALCITE-4546 Change metadata dispatch to avoid registration of all RelNode subtypes
• links to: GitHub Pull Request #2567