[CALCITE-4818] AggregateExpandDistinctAggregatesRule must infer correct data type for top aggregate calls

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.27.0
• Fix Version/s: 1.29.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Taras Ledkov
• Reporter: Taras Ledkov
• Created: 01/Oct/21 13:07
• Updated: 04/Jan/22 08:27
• Resolved: 04/Jan/22 08:27

Description

When SUM data type derivation is more complex, e.g.:

SUM(TINYINT | SMALLINT | INTEGER) -> BIGINT
SUM(BIGINT) -> DECIMAL

The rule AggregateExpandDistinctAggregatesRule creates the top aggregate calls with invalid type for not distinct calls.

e.g. SELECT SUM(comm), SUM(DISTINCT comm) FROM emp

Please take a look at the reproducer in the PR.

Proposed fix: infer type of top aggregates by input row type. Pass null type to the call method AggregateCall#create.

Issue Links

• relates to: CALCITE-4652 AggregateExpandDistinctAggregatesRule must cast top aggregates to original type
• links to: GitHub Pull Request #2560
• links to: GitHub Pull Request #2560