[CALCITE-479] Migrate RelNode.getChildExps to RelNode.accept(RexShuttle)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0-incubating
• Fix Version/s: 1.0.0-incubating
• Labels: newbie
• Assignee: Julian Hyde
• Reporter: Vladimir Sitnikov
• Created: 24/Nov/14 09:51
• Updated: 08/Feb/15 08:56
• Resolved: 18/Dec/14 07:32

Description

> What if we kill RelNode.getChildExps and add RelNode
> RelNode.accept(RexShuttle shuttle) instead?

julianhyde
+1 That method is very general-purpose. I like it.

It should respect the immutability of RelNodes and return a new
RelNode iff there are changes. Most RelNodes, except sub-classes of
project, filter, join, will just 'return this' right away.

The shuttle must make only very limited changes. Even changing the
output type of an expression should not be allowed. We can relax these
restrictions later, if justified.