Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-474

Clean up rule naming in order to support enabling/disabling rules

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      (comment from Julian):
      We already require rule classes to have canonical names. By default, we use the class name (sans package). We should tighten up and allow names to only include [A-Za-z0-9$_.].

        Activity

        Hide
        julianhyde Julian Hyde added a comment -

        Closing now that 1.0.0-incubating has been released.

        Show
        julianhyde Julian Hyde added a comment - Closing now that 1.0.0-incubating has been released.
        Hide
        julianhyde Julian Hyde added a comment -

        Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/7882a5b9.

        The actual pattern I used for valid descriptions is "[A-Za-z][-A-Za-z0-9_.():]*". The change also makes sure that descriptions are unique within an instance of VolcanoPlanner.

        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/7882a5b9 . The actual pattern I used for valid descriptions is " [A-Za-z] [-A-Za-z0-9_.():] *". The change also makes sure that descriptions are unique within an instance of VolcanoPlanner.

          People

          • Assignee:
            julianhyde Julian Hyde
            Reporter:
            amansinha100 Aman Sinha
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development