[CALCITE-4698] Respect input types and precision for datetime '+' operator and TIMESTAMPADD function

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.35.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Caizhi Weng
• Created: 19/Jul/21 08:27
• Updated: 27/Jul/23 10:22
• Resolved: 28/Apr/23 06:24

Description

Currently SqlTimestampAddFunction#deduceType does not deal with timestamp_ltz type correctly. Return type of timestampadd(..., ..., timestamp_ltz) will be timestamp but it should be timestamp_ltz.
Same issue is for precision datetime_plus.
Also precision is lost.

A number of queries highlighting the issue

SELECT timestamp '2003-08-02 12:54:01' - INTERVAL '1.123' SECOND(1, 3);
SELECT time '12:12:12' + INTERVAL '3.456' SECOND(1, 3);
SELECT timestampadd(SQL_TSI_FRAC_SECOND, 2, timestamp with local time zone '2016-02-24 12:42:25.000');

Issue Links

• causes: FLINK-22861 TIMESTAMPADD + timestamp_ltz type throws CodeGenException
• is related to: CALCITE-5266 Increase precision of TIMESTAMP, INTERVAL types to microseconds, nanoseconds
• links to: GitHub Pull Request #3104