[CALCITE-4570] Always validate preconditions in Filter, Correlate, Snapshot expressions when assertions are enabled

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.27.0
• Labels: pull-request-available
• Assignee: Stamatis Zampetakis
• Reporter: Stamatis Zampetakis
• Created: 09/Apr/21 11:31
• Updated: 03/Jun/21 22:32
• Resolved: 12/Apr/21 09:04

Description

At the moment precondition validation is performed in Filter, Correlate, Snapshot constructors only when CalciteSystemProperty.DEBUG is true and assertions are enabled.

Most of the time CalciteSystemProperty.DEBUG is set to false so the checks are not performed which could lead to problems that are difficult to spot. Failing fast when there is an obvious problem in the structure of the plan is a great help for fixing issues that may also remain unnoticed for a very long time.

The goal of this issue is to always validate preconditions in the constructor of Filter, Correlate, and Snapshot regardless if CalciteSystemProperty.DEBUG is enabled or not. To avoid the performance overhead in production the assertions can be disabled as it usually happens.

Issue Links

• links to: GitHub Pull Request #2389