[CALCITE-4526] SqlSnapshot unparse lost the AS keyword when the table has alias

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.26.0
• Fix Version/s: 1.27.0
• Component/s: core
• Labels: pull-request-available
• Assignee: jibiyr
• Reporter: jibiyr
• Created: 09/Mar/21 07:27
• Updated: 03/Jun/21 22:32
• Resolved: 11/Mar/21 11:35

Description

hi,community. now calcite support SqlSnapshot. 

when a sql like SELECT orders.order_id, products.pro_id, products.product_name
FROM default_catalog.default_database.orders AS orders
LEFT JOIN default_catalog.default_database.products FOR SYSTEM_TIME AS OF orders.proctime AS products ON orders.product_id = products.pro_id .

 

default_catalog.default_database.products FOR SYSTEM_TIME AS OF orders.proctime AS products  parse to SqlSnapshot .however, when unparse. it is default_catalog.default_database.products AS products FOR SYSTEM_TIME AS OF orders.proctime. which can not be parsed again.

 

if we should consider this condition.

the same problem when I found in FLINK-19670.
 

Issue Links

• causes: FLINK-19670 Query on a view of temporal join throws ParseException
• is duplicated by: CALCITE-4527 SqlSnapshot unparse problem when tablRef is As-SqlBasicCall
• is related to: CALCITE-1912 Support "FOR SYSTEM_TIME AS OF" in regular queries
• links to: GitHub Pull Request #2366