[CALCITE-4510] RexLiteral can produce wrong digest for some user defined types

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.27.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Liya Fan
• Reporter: Liya Fan
• Created: 23/Feb/21 03:44
• Updated: 03/Jun/21 22:32
• Resolved: 28/May/21 08:28

Description

We find weird literals for some user defined non-nullable types. Some investigation shows that the problem lies in the RexLiteral#toJavaString method.

In particular, it checks the type string suffix with an 8-character string:

if (!fullTypeString.endsWith("NOT NULL")) {

However, it trims the last 9 characters from the end of the string:

sb.append(fullTypeString, 0, fullTypeString.length() - 9);

Issue Links

• links to: GitHub Pull Request #2356