[CALCITE-4450] ElasticSearch query with varchar literal projection fails with JsonParseException

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.26.0
• Fix Version/s: 1.27.0
• Labels: pull-request-available
• Assignee: Vova Vysotskyi
• Reporter: Vova Vysotskyi
• Created: 30/Dec/20 22:20
• Updated: 03/Jun/21 22:31
• Resolved: 06/Jan/21 21:43

Description

A query that contains varchar literals in projection fails for ElasticSearch adapter. Simple test case to reproduce the issue:

@Test void projectionStringLiteral() {
    CalciteAssert.that()
        .with(newConnectionFactory())
        .query(
            String.format(Locale.ROOT, "select 'foo' as \"lit\"\n"
                + "from \"elastic\".\"%s\"", NAME))
        .returns("lit=foo\n");
  }

Error:

Caused by: com.fasterxml.jackson.core.JsonParseException: Unexpected character ('f' (code 102)): was expecting comma to separate Object entries
 at [Source: (String)"{"script_fields": {"lit":{"script": ""foo""}, "a":{"script": "params._source.a"}}}"; line: 1, column: 40]
	at com.fasterxml.jackson.core.JsonParser._constructError(JsonParser.java:1840)

The problem is that RexToElasticsearchTranslator.visitLiteral method do not escape literal quotes, and forms the following string: "lit":""foo"" that cannot be handled by jackson.

Issue Links

• links to: GitHub Pull Request #2308