Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-444

Filters wrongly pushed into full outer join

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.2-incubating
    • Component/s: None
    • Labels:
      None

      Description

      Filter R1.x=10 (R1 full outer join R2 on R1.y=R2.y)
      Gets rewritten as
      R1 left outer join R2 on R1.y=R2.y and R1.x=10.

      This is obviously wrong and produces wrong result.

      select count from(select ss.ss_sold_date_sk, ss.ss_item_sk, ss.ss_customer_sk from store_sales ss full outer join date_dim d on ss.ss_sold_date_sk = d.d_date_sk where ss.ss_item_sk = 4496)R;
      produces wrong result due to above described problem.

      Patch separates the join simplification from Join filter classification.
      Predicate Push Down through Join would first simplify Outer Joins before applying predicate push down.

      1. CALCITE-444.1.patch
        18 kB
        Laljo John Pullokkaran
      2. CALCITE-444.patch
        16 kB
        Laljo John Pullokkaran

        Activity

        Hide
        julianhyde Julian Hyde added a comment -

        Bulk update closing "fixed" issues that are more than a year old.

        Show
        julianhyde Julian Hyde added a comment - Bulk update closing "fixed" issues that are more than a year old.
        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/e4fcf2a3 .

          People

          • Assignee:
            jpullokkaran Laljo John Pullokkaran
            Reporter:
            jpullokkaran Laljo John Pullokkaran
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development