[CALCITE-4380] Make class SqlNodeList implement List<SqlNode>

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.27.0
• Assignee: Julian Hyde
• Reporter: Julian Hyde
• Created: 06/Nov/20 00:15
• Updated: 03/Jun/21 22:31
• Resolved: 13/Nov/20 06:00

Description

Make class SqlNodeList implement List<SqlNode>. Currently it implements Iterable<SqlNode>. Supporting the List interface would make the size available, and that might allow users of SqlNodeList to pre-allocate space.

The downside is that a few places might have different overloads on SqlNode and Collection<SqlNode> or List<SqlNode>, and these would become ambiguous because SqlNodeList implements both.

Another benefit is that we can remove many of the calls to List<SqlNode> SqlNodeList.toList().

See email thread on dev@calcite.