Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.2-incubating
    • Component/s: None
    • Labels:
      None
    1. OPTIQ-438.1.patch
      6 kB
      Laljo John Pullokkaran
    2. OPTIQ-438.patch
      4 kB
      Laljo John Pullokkaran

      Activity

      Hide
      julianhyde Julian Hyde added a comment -

      As it stands, this patch is not acceptable. It does not enhance Optiq; it just drills a hole so that (I presume) Hive can add its own functionality. There are no tests. The description is not plain English (I presume PPD means 'predicate pushdown'). And the patch does not do what the description says, because clearly half of the implementation is in the sub-class, which you have not contributed.

      Show
      julianhyde Julian Hyde added a comment - As it stands, this patch is not acceptable. It does not enhance Optiq; it just drills a hole so that (I presume) Hive can add its own functionality. There are no tests. The description is not plain English (I presume PPD means 'predicate pushdown'). And the patch does not do what the description says, because clearly half of the implementation is in the sub-class, which you have not contributed.
      Hide
      jpullokkaran Laljo John Pullokkaran added a comment -

      The patch has two aspects:
      1. It enables pushing of predicate through SemiJoin
      2. It allows customization of Predicate Push Down Logic
      Hive only allows equality predicates and functions that refer to only child of Join in ON clause.
      I discussed this with you and i thought we agreed on this strategy.

      I can modify the patch to add unit test.

      Show
      jpullokkaran Laljo John Pullokkaran added a comment - The patch has two aspects: 1. It enables pushing of predicate through SemiJoin 2. It allows customization of Predicate Push Down Logic Hive only allows equality predicates and functions that refer to only child of Join in ON clause. I discussed this with you and i thought we agreed on this strategy. I can modify the patch to add unit test.
      Hide
      julianhyde Julian Hyde added a comment -

      Thanks for the updates, John. It's all good now. I have checked the patch into https://github.com/julianhyde/optiq/tree/master. I will push to apache master when the release vote closes.

      Show
      julianhyde Julian Hyde added a comment - Thanks for the updates, John. It's all good now. I have checked the patch into https://github.com/julianhyde/optiq/tree/master . I will push to apache master when the release vote closes.
      Show
      julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-optiq/commit/59191a7a .
      Hide
      julianhyde Julian Hyde added a comment -

      Bulk update closing "fixed" issues that are more than a year old.

      Show
      julianhyde Julian Hyde added a comment - Bulk update closing "fixed" issues that are more than a year old.

        People

        • Assignee:
          julianhyde Julian Hyde
          Reporter:
          jpullokkaran Laljo John Pullokkaran
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development