Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-4350

The reverse operation of collation direction is overly relaxed

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.27.0
    • Component/s: core

      Description

      For the current implementation, RelFieldCollation#Direction#reverse returns DESCENDING for STRICTLY_ASCENDING, and returns ASCENDING for STRICTLY_DESCENDING.

      This is overly relaxed. In a strict manner, it should return STRICTLY_DESCENDING for STRICTLY_ASCENDING, and vice versa. 

      If the user needs to get the relaxed reverse direction, they may call collation.getDirection().reverse().lax();, as in many places of our code base. 

      Do you agree?

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                fan_li_ya Liya Fan
                Reporter:
                fan_li_ya Liya Fan
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m