Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-434

FilterAggregateTransposeRule loses conditions that cannot be pushed

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Critical
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 0.9.2-incubating
        • Component/s: None
        • Labels:
          None

          Description

          current FilterAggregateTransposeRule is not correct. the predicates that can not pass agg will disappear silently.

          1. Text File
            OPTIQ-434.1.patch
            6 kB
            Pengcheng Xiong
          2. Text File
            OPTIQ-434.2.patch
            4 kB
            Pengcheng Xiong

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            pxiong Pengcheng Xiong added a comment -

            create a new filter for the predicates that can not pass agg.

            Show
            pxiong Pengcheng Xiong added a comment - create a new filter for the predicates that can not pass agg.
            Hide
            Permalink
            pxiong Pengcheng Xiong added a comment -

            Gunther Hagleitner, this will solve data correctness problems for ppd_gby.q, ppd_gby2.q, ppd_gby_join.q

            Show
            pxiong Pengcheng Xiong added a comment - Gunther Hagleitner , this will solve data correctness problems for ppd_gby.q, ppd_gby2.q, ppd_gby_join.q
            Hide
            Permalink
            julianhyde Julian Hyde added a comment -

            Pengcheng Xiong A few review comments. Can you submit a new patch with these fixed.

            1. There are a few spurious diffs, where lines have been re-formatted for no reason. Can you remove these.

            2. In RelOptRulesTest.xml, the SQL for testPushFilterWithRank has been changed. Is there a good reason for this? If not please back out.

            3. Please rename the variable "conditionsRemain" to "remainingConditions" so that it is consistent with "pushedConditions".

            Show
            julianhyde Julian Hyde added a comment - Pengcheng Xiong A few review comments. Can you submit a new patch with these fixed. 1. There are a few spurious diffs, where lines have been re-formatted for no reason. Can you remove these. 2. In RelOptRulesTest.xml, the SQL for testPushFilterWithRank has been changed. Is there a good reason for this? If not please back out. 3. Please rename the variable "conditionsRemain" to "remainingConditions" so that it is consistent with "pushedConditions".
            Hide
            Permalink
            pxiong Pengcheng Xiong added a comment -

            patch after addressing code review from Julian.

            Show
            pxiong Pengcheng Xiong added a comment - patch after addressing code review from Julian.
            Hide
            Permalink
            julianhyde Julian Hyde added a comment -

            Pengcheng Xiong looks good. I will commit when check-ins resume after release 0.9.1.

            Show
            julianhyde Julian Hyde added a comment - Pengcheng Xiong looks good. I will commit when check-ins resume after release 0.9.1.
            Hide
            Permalink
            julianhyde Julian Hyde added a comment -

            Fixed in http://git-wip-us.apache.org/repos/asf/incubator-optiq/commit/44c72c32.

            Show
            julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-optiq/commit/44c72c32 .
            Hide
            Permalink
            julianhyde Julian Hyde added a comment -

            Bulk update closing "fixed" issues that are more than a year old.

            Show
            julianhyde Julian Hyde added a comment - Bulk update closing "fixed" issues that are more than a year old.

              People

              • Assignee:
                julianhyde Julian Hyde
                Reporter:
                pxiong Pengcheng Xiong
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development