[CALCITE-4332] Improve error when planning rule produces a relational expression with wrong row type - ASF JIRA

Voters

Watch issue

Watchers

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.26.0
Fix Version/s: 1.27.0
Component/s: core
Labels:
- pull-request-available

Description

Current code in VolcanoPlanner:

      assert RelOptUtil.equal(
          "rel rowtype",
          rel.getRowType(),
          "equivRel rowtype",
          equivRel.getRowType(),
          Litmus.THROW);
      equivRel = ensureRegistered(equivRel, null);

The suggested changes:
1) Use regular error IllegalArgumentException rather than an assertion
2) Make sure the exception message contains fine-grained information on what went wrong. For instance: name: non nullable -> nullable; description: character -> int; ...