[CALCITE-4320] JdbcRules JOIN_FACTORY, AGGREGATE_FACTORY, SET_OP_FACTORY, ... create relations with wrong convention

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Abandoned
• Affects Version/s: 1.26.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Vladimir Sitnikov
• Created: 08/Oct/20 10:50
• Updated: 15/Nov/20 11:04
• Resolved: 15/Nov/20 11:04

Description

  static final RelFactories.JoinFactory JOIN_FACTORY =
      (left, right, hints, condition, variablesSet, joinType, semiJoinDone) -> {
        final RelOptCluster cluster = left.getCluster();
        final RelTraitSet traitSet = cluster.traitSetOf(left.getConvention());
        try {
          return new JdbcJoin(cluster, traitSet, left, right, condition,
              variablesSet, joinType);

In practice, JdbcJoin should use JdbcConvention rather than cluster.traitSetOf(left.getConvention());

I wonder if RelFactories in JdbcRules are dead code.

Issue Links

• links to: GitHub Pull Request #2202