Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-4314

Enable Error Prone checking

    XMLWordPrintableJSON

    Details

      Description

      Error-Prone would fail the build when it detects violations. The test code is not verified.
      The check takes 4-5 minutes.
      One can execute the verification locally via ./gradlew -PenableErrorpone -Pwerror=false classes
      Calcite uses Werror by default to fail on javac warnings, so -Pwerror=false allows Error-Prone to display all the warnings.


      Most of the changes (35 commits in total, +5,779 −5,015) are for the following checks:

      Add missing @Override annotations
       745 files changed, 4490 insertions(+), 4456 deletions(-)
      
      Add missing default branches to switch statement
       98 files changed, 691 insertions(+), 55 deletions(-)
      
      Remove unused fields, methods, and variables
       79 files changed, 104 insertions(+), 149 deletions(-)
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                vladimirsitnikov Vladimir Sitnikov
                Reporter:
                vladimirsitnikov Vladimir Sitnikov
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: