[CALCITE-4301] Unit tests for Cassandra adapter are wrongly applying ITEM operator to STRUCT columns

• Type: Test
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.25.0
• Fix Version/s: 1.27.0
• Component/s: cassandra-adapter
• Labels: pull-request-available
• Assignee: Alessandro Solimando
• Reporter: Alessandro Solimando
• Created: 01/Oct/20 21:59
• Updated: 22/Sep/21 00:02
• Resolved: 09/Oct/20 16:58

Description

The following unit tests included in "cassandra/src/test/java/org/apache/calcite/test/CassandraAdapterDataTypesTest.java" are wrong, as they apply ITEM operator to a struct column _f_tuple_, instead of the DOT operator. 

@Test void testCollectionsInnerRowType() {
  CalciteAssert.that()
      .with(DTCASSANDRA)
      .query("select \"f_list\"[1], "
          + "\"f_map\"['k1'], "
          + "\"f_tuple\"['1'], "
          + "\"f_tuple\"['2'], "
          + "\"f_tuple\"['3']"
          + " from \"test_collections\"")
      .typeIs("[EXPR$0 INTEGER"
          + ", EXPR$1 VARCHAR"
          + ", EXPR$2 BIGINT"
          + ", EXPR$3 VARBINARY"
          + ", EXPR$4 TIMESTAMP]");
}

@Test void testCollectionsInnerValues() {
       CalciteAssert.that()
           .with(DTCASSANDRA)
           .query("select \"f_list\"[1], "
               + "\"f_map\"['k1'], "
               + "\"f_tuple\"['1'], "
               + "\"f_tuple\"['2'], "
               + "\"f_tuple\"['3']"
               + " from \"test_collections\"")
           .returns("EXPR$0=1"
               + "; EXPR$1=v1"
               + "; EXPR$2=3000000000"
               + "; EXPR$3=30ff87"
               + "; EXPR$4=2015-05-03 13:30:54.234");
}

 

Issue Links

• relates to: CALCITE-4293 cassandra adapter returns null when selecting non-null tuple elements
• relates to: CALCITE-4789 Build is broken on Guava versions < 21
• links to: GitHub Pull Request #2199