Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-4287

AggregateJoinRemoveRule and ProjectJoinRemoveRule are not fired if the last column of the join's left input is referenced

    XMLWordPrintableJSON

    Details

      Description

      In some rules (e.g. AggregateJoinRemoveRule#onMatch), the logic of checking if the aggregate references any columns from the other side is incorrect.

      For example, given an aggregate on a left join, the logic checks if the aggregate references any columns from the right side. If the aggregate happens to references the last column of the left input, the current implementation will make a wrong decision to skip the rule match.  

      This will miss opportunities of simplifying the plan. 

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                fan_li_ya Liya Fan
                Reporter:
                fan_li_ya Liya Fan
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 50m
                  50m