[CALCITE-4287] AggregateJoinRemoveRule and ProjectJoinRemoveRule are not fired if the last column of the join's left input is referenced

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.26.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Liya Fan
• Reporter: Liya Fan
• Created: 27/Sep/20 09:41
• Updated: 06/Oct/20 17:16
• Resolved: 29/Sep/20 07:20

Description

In some rules (e.g. AggregateJoinRemoveRule#onMatch), the logic of checking if the aggregate references any columns from the other side is incorrect.

For example, given an aggregate on a left join, the logic checks if the aggregate references any columns from the right side. If the aggregate happens to references the last column of the left input, the current implementation will make a wrong decision to skip the rule match.  

This will miss opportunities of simplifying the plan. 

Issue Links

• links to: GitHub Pull Request #2177