Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-4284

ImmutableBeans: make reference properties non-nullable by default

Rank to TopRank to BottomBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersConvert to sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.25.0
    • 1.27.0
    • core
    • None

    Description

      The rule of thumb is to avoid null, and it would be better to make properties non-nullable by default, and use annotations to permit nullable types.

      I believe that would make org.apache.calcite.util.ImmutableBeans.Property#required obsolete.

      Attachments

        Issue Links

        relates to

        Bug - A problem which impairs or prevents the functions of the product. CALCITE-4520 In ImmutableBeans, nullable properties become not-nullable in project that excludes checkerframework from its runtime

        • Major - Major loss of function.
        • Closed

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            vladimirsitnikov Vladimir Sitnikov
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment