Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-4098

Remove redundant code in "RelJson.toJson(RelDistribution)"

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.24.0
    • Component/s: core
    • Labels:
      None

      Description

      RelDistribution#getKeys is annotated as nonnull, and must return "List<Integer>", so this code is unnecessary.

       

      List<Object> keys = new ArrayList<>(relDistribution.getKeys().size()); 
       for (Integer key : relDistribution.getKeys()) {
        keys.add(toJson(key));
      }
       
      

       

       

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Aron.tao Jiatao Tao
                Reporter:
                Aron.tao Jiatao Tao
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 50m
                  1h 50m