Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-4098

Remove redundant code in "RelJson.toJson(RelDistribution)"

Rank to TopRank to BottomBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersConvert to sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 1.24.0
    • core
    • None

    Description

      RelDistribution#getKeys is annotated as nonnull, and must return "List<Integer>", so this code is unnecessary.

       

      List<Object> keys = new ArrayList<>(relDistribution.getKeys().size()); 
       for (Integer key : relDistribution.getKeys()) {
        keys.add(toJson(key));
      }
       
      

       

       

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Aron.tao Jiatao Tao
            Aron.tao Jiatao Tao
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 50m
                1h 50m

                Slack

                  Issue deployment