Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-4083

RelTraitSet failed to canonize traits

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.24.0
    • Component/s: core
    • Labels:
      None

      Description

      RelTraitSet#plus uses FlatLists and ImmutableList. They have different hash algorithms, and they are all different classes from RelTraitSet. The RelTraitSet equality requires the other object must be RelTraitSet too, and the HashMap#get(key) uses key.equals() to check equality, instead of the other way. In case we pass RelTraitSet as the search key to cache, but the cached entry has key with FlatLists or ImmutableList, we may fail to find the cached RelTraitSet. Due to this, using == to check traitSet equality may fail, even they have same traits.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              hyuan Haisheng Yuan
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 20m
                20m