[CALCITE-4042] JoinCommuteRule must not match SEMI / ANTI join

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.23.0
• Fix Version/s: 1.24.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Ruben Q L
• Reporter: Ruben Q L
• Created: 04/Jun/20 08:53
• Updated: 25/Jul/20 14:59
• Resolved: 04/Jun/20 15:22

Description

JoinCommuteRule must not match SEMI / ANTI join, because these types cannot be swapped.

This is a minor issue, because the "default" JoinCommuteRule.INSTANCE matches only INNER joins. However, there is another version of the rule (JoinCommuteRule.SWAP_OUTER, currently only used in a few unit tests), to match also outer joins, which could potentially match a SEMI / ANTI join.

Issue Links

• is duplicated by: CALCITE-3911 JoinCommuteRule may generate wrong plan for SEMI/ANTI join
• links to: PR#2002