Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-3980

Redis-adapter redis connection is not reused when RedisTable is created

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 1.23.0
    • None
    • None

    Description

      When creating RedisTable via ModelHandler, it relies on an instance method RedisEnumerator#deduceRowType to extract field type map, redis connection will be established and closed every time a table is created, which is unnecessary and redundant, so simply make the method a static one will solve the problem and make it more performant. Actually, CsvTable implementation works the right way.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            neoremind neoremind
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 40m
                40m

                Slack

                  Issue deployment