[CALCITE-3980] Redis-adapter redis connection is not reused when RedisTable is created - ASF JIRA

Voters

Watch issue

Watchers

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 1.23.0
Component/s: None
Labels:
None

Description

When creating RedisTable via ModelHandler, it relies on an instance method RedisEnumerator#deduceRowType to extract field type map, redis connection will be established and closed every time a table is created, which is unnecessary and redundant, so simply make the method a static one will solve the problem and make it more performant. Actually, CsvTable implementation works the right way.

Attachments

Activity

Comment

This comment will be Viewable by All Users Viewable by All Users

Cancel

People

Assignee:: Unassigned

Reporter:: neoremind

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 08/May/20 10:30

Updated:: 24/May/20 12:00

Resolved:: 10/May/20 15:54

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

Redis-adapter redis connection is not reused when RedisTable is created