[CALCITE-3898] RelOptPredicateList may generate incorrect map of constant values

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 1.23.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Jesús Camacho Rodríguez
• Reporter: Jesús Camacho Rodríguez
• Created: 06/Apr/20 17:35
• Updated: 27/Feb/24 22:23
• Resolved: 08/Apr/20 04:03

Description

The method relies on RexUtil.predicateConstants which in turn calls RexUtil.canAssignFrom. RexUtil.canAssignFrom is skipping any check on precision and scale. I observed the error in Hive when two VARCHAR types with different precision were given to the method, which was resulting on considering the result of the narrowing cast as the value of the reference. This lead to incorrect results.

Issue Links

• is related to: HIVE-23100 Create RexNode factory and use it in CalcitePlanner
• links to: GitHub Pull Request #1899