[CALCITE-3892] Make junit test classes and methods non-public

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.23.0
• Assignee: Julian Hyde
• Reporter: Julian Hyde
• Created: 02/Apr/20 02:54
• Updated: 24/May/20 12:00
• Resolved: 07/Apr/20 11:35

Description

In junit 4 and earlier versions, junit classes and methods must be public. In junit 5 (jupiter) this is no longer the case.

This change makes classes and methods package-protected where possible (i.e. removes the "public" modifier). It makes tests a bit more concise, and gives us more freedom to refactor tests in future.