Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-3870

Change the default value of SqlToRelConverter.Config.expand from true to false

Rank to TopRank to BottomBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersConvert to sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      Set "SqlToRelConverter.ConfigBuilder#expand" default to false. Now the default "expand" in  SqlToRelConverter.ConfigBuilder is true but in calcite's main process, actually, it is false( withExpand(THREAD_EXPAND.get()))
       
      That leads we need to explicitly set withExpand to false when we use SqlToRelConverter.
       
      So I think we should change the default to "false" in SqlToRelConverter.ConfigBuilder.
       

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            julianhyde Julian Hyde
            Aron.tao Jiatao Tao
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 50m
                1h 50m

                Slack

                  Issue deployment