[CALCITE-3812] Refactor HintStrategy to HintPredicate

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.22.0
• Fix Version/s: 1.22.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Danny Chen
• Reporter: Danny Chen
• Created: 21/Feb/20 03:34
• Updated: 06/Mar/20 04:34
• Resolved: 21/Feb/20 04:55

Description

The HintStrategy was introduced in commit https://github.com/apache/calcite/commit/52bc246d5e07510689635f407f4d9dc494b0af4d, at that moment, we can only define the hint match rules for propagation, and the class name is okey.

But with more components added to the HintStrategyTable(i.e. the HintOptionChecker, the error hander, the excluded rules), i found the "HintStrategy" is mis-leading.

So i propose to rename HintStrategy to HintPredicate and HintStrategyTable.Entry to HintStrategy.

I want this change to be included in 1.22.0.

Issue Links

• links to: GitHub Pull Request #1820
• links to: GitHub Pull Request #1823