XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.22.0
    • Fix Version/s: 1.22.0
    • Component/s: core

      Description

      The HintStrategy was introduced in commit https://github.com/apache/calcite/commit/52bc246d5e07510689635f407f4d9dc494b0af4d, at that moment, we can only define the hint match rules for propagation, and the class name is okey.

      But with more components added to the HintStrategyTable(i.e. the HintOptionChecker, the error hander, the excluded rules), i found the "HintStrategy" is mis-leading.

      So i propose to rename HintStrategy to HintPredicate and HintStrategyTable.Entry to HintStrategy.

      I want this change to be included in 1.22.0.

        Attachments

          Activity

            People

            • Assignee:
              danny0405 Danny Chen
              Reporter:
              danny0405 Danny Chen
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 40m
                40m