[CALCITE-3807] checkForSatisfiedConverters() is unnecessary

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.22.0
• Labels: pull-request-available
• Assignee: Danny Chen
• Reporter: Xiening Dai
• Created: 19/Feb/20 23:08
• Updated: 06/Mar/20 04:35
• Resolved: 21/Feb/20 03:56

Description

When VolcanoPlanner registers an abstract converter, it adds the converter into set.abstractConverters list, then calls checkSatisfiedConverter() to see if any converter is satisfied and can be remove from the list. But for every abstract converter, it always satisfies itself (changeTraitsUsingConverters() returns itself). Basically the converter would be removed from the list right after it's added. So this check is completely unnecessary and it slows down the planner.

Issue Links

• links to: GitHub Pull Request #1817