[CALCITE-3773] Wrong parameter in EnumerableMergeJoin::create method

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.21.0
• Fix Version/s: 1.22.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Ruben Q L
• Reporter: Ruben Q L
• Created: 05/Feb/20 15:12
• Updated: 06/Mar/20 04:35
• Resolved: 06/Feb/20 08:04

Description

The public EnumerableMergeJoin::create method takes a RexLiteral condition as parameter:

  public static EnumerableMergeJoin create(
      RelNode left, RelNode right,
      RexLiteral condition,  // here!
      ImmutableIntList leftKeys, ImmutableIntList rightKeys, JoinRelType joinType) {
    ...
  }

However, in the actual (package-private) constructor (and in the parent Join class), the condition is defined as a RexNode:

  EnumerableMergeJoin(
      RelOptCluster cluster,
      RelTraitSet traits,
      RelNode left,
      RelNode right,
      RexNode condition,  // here!
      Set<CorrelationId> variablesSet,
      JoinRelType joinType) {
    ...
  }

Therefore, the create method parameter must be fixed.

Issue Links

• links to: GitHub Pull Request #1786