[CALCITE-3771] Support of TRIM function for SPARK dialect and improvement in HIVE Dialect

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.22.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Danny Chen
• Reporter: Dhirenda Gautam
• Created: 05/Feb/20 13:43
• Updated: 06/Mar/20 04:36
• Resolved: 20/Feb/20 04:32

Description

In current Calcite implementation for query : SELECT TRIM('ABC') for SPARK Dialect it gets translated into SELECT TRIM(BOTH ' ' FROM 'ABC') .

But the proper query for SPARK is :: SELECT TRIM('ABC')

Unparse logic for the trim has been handled in Spark dialect to convert the source Trim query into valid SPARK query.

 

Also,In HIVE/SPARK dialect TRIM with two operand is not supported

Eg: SELECT TRIM(BOTH 'a' from 'ABC') So its equivalent is REGEXP_REPLACE which is handle in unparseTrim function.

Issue Links

• links to: GitHub Pull Request #1785
• links to: PR#1785