Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-3769

Deprecate TableScanRule

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      The TableScanRule is the only planner rule that for a logical node(e.g. the table scan), its function is to pass along the cluster object and invoke the RelOptTable#toRel which is very trivial because it supplies only a simple ToRelContext that does not support expanding view/passing table hints.

      For rels that come from the sql-to-rel conversion, there is already a table conversion logic[1]. This code gives a more powerful ToRelContext that has the complete functionality.

      The only reason that I saw the meaning of existing TableScanRule is for the TableScan that comes from the RelBuilder#scan.

      So I would suggest to deprecate the TableScanRule, instead, we support translating the table directly in RelBuilder#scan,

      We also add a new interface RelBuilder#scan(Iterable<String> tableNames, ToRelContext context), so that user can pass in a more powerful ToRelContext explicitly. User can customize a TableScanFactory in the RelBuilder to do this.

      [1] https://github.com/apache/calcite/blob/d6fa25cd11625ad7b4b74dafbd0211c701b38d49/core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java#L3498

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            danny0405 Danny Chen
            danny0405 Danny Chen
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 2h 50m
                2h 50m

                Slack

                  Issue deployment