[CALCITE-3738] Missing LogicalSort for INSERT statement

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.19.0
• Fix Version/s: 1.22.0
• Component/s: core
• Labels: pull-request-available
• Assignee: pengzhiwei
• Reporter: pengzhiwei
• Created: 15/Jan/20 07:01
• Updated: 06/Mar/20 04:34
• Resolved: 28/Jan/20 17:52

Description

The following sql statement generates a wrong logical plan which missing the LogicalSort :

insert into t select id*10,name from users order by name;

the plan is :

LogicalTableModify(table=[[t]], operation=[INSERT], flattened=[false])
  LogicalProject(id=[*($0, 10)], name=[$1])
    LogicalTableScan(table=[[users]])

This issue is introduced by the issue https://issues.apache.org/jira/browse/CALCITE-2978 

which removes the sort by in sub-query.However the query in insert statement is not a sub-query.

Issue Links

• Blocked: CALCITE-2978 sorting not applied in subqueries
• links to: GitHub Pull Request #1763