[CALCITE-3676] VolcanoPlanner. dumpGraphviz should handle exception gracefully

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.22.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Forward Xu
• Reporter: Haisheng Yuan
• Created: 04/Jan/20 09:18
• Updated: 06/Mar/20 07:35
• Resolved: 28/Jan/20 02:14

Description

In case VolcanoPlanner can't generate plan due to some RelSubset doesn't have best rel, it will dump the sets and Graphviz. Since there is error during planning, we want to see the sets in the exception message, but when dumping Graphviz, it might encounter another exception (we can't guarantee all the sets and subsets are correctly generated for Graphviz), causing failure to dump Sets info, which is rather helpful in production system.

Caused by: java.lang.AssertionError
	at org.apache.calcite.util.PartiallyOrderedSet.findParentsChildren(PartiallyOrderedSet.java:318)
	at org.apache.calcite.util.PartiallyOrderedSet.findParents(PartiallyOrderedSet.java:308)
	at org.apache.calcite.util.PartiallyOrderedSet.add(PartiallyOrderedSet.java:226)
	at org.apache.calcite.plan.volcano.VolcanoPlanner.dumpGraphviz(VolcanoPlanner.java:1320)
	at org.apache.calcite.plan.volcano.VolcanoPlanner.dump(VolcanoPlanner.java:1194)
	at org.apache.calcite.plan.volcano.RelSubset$CheapestPlanReplacer.visit(RelSubset.java:606)
	at org.apache.calcite.plan.volcano.RelSubset.buildCheapestPlan(RelSubset.java:307)
	at org.apache.calcite.plan.volcano.VolcanoPlanner.findBestExp(VolcanoPlanner.java:649)

Issue Links

• links to: GitHub Pull Request #1759