Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-3676

VolcanoPlanner. dumpGraphviz should handle exception gracefully

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      In case VolcanoPlanner can't generate plan due to some RelSubset doesn't have best rel, it will dump the sets and Graphviz. Since there is error during planning, we want to see the sets in the exception message, but when dumping Graphviz, it might encounter another exception (we can't guarantee all the sets and subsets are correctly generated for Graphviz), causing failure to dump Sets info, which is rather helpful in production system.

      Caused by: java.lang.AssertionError
      	at org.apache.calcite.util.PartiallyOrderedSet.findParentsChildren(PartiallyOrderedSet.java:318)
      	at org.apache.calcite.util.PartiallyOrderedSet.findParents(PartiallyOrderedSet.java:308)
      	at org.apache.calcite.util.PartiallyOrderedSet.add(PartiallyOrderedSet.java:226)
      	at org.apache.calcite.plan.volcano.VolcanoPlanner.dumpGraphviz(VolcanoPlanner.java:1320)
      	at org.apache.calcite.plan.volcano.VolcanoPlanner.dump(VolcanoPlanner.java:1194)
      	at org.apache.calcite.plan.volcano.RelSubset$CheapestPlanReplacer.visit(RelSubset.java:606)
      	at org.apache.calcite.plan.volcano.RelSubset.buildCheapestPlan(RelSubset.java:307)
      	at org.apache.calcite.plan.volcano.VolcanoPlanner.findBestExp(VolcanoPlanner.java:649)
      

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            x1q1j1 Forward Xu
            hyuan Haisheng Yuan
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 20m
                1h 20m

                Slack

                  Issue deployment