[CALCITE-3623] Replace Spotless with Autostyle

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.21.0
• Fix Version/s: 1.22.0, avatica-1.17.0
• Component/s: avatica, core
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Vladimir Sitnikov
• Created: 22/Dec/19 22:18
• Updated: 06/Mar/20 04:35
• Resolved: 28/Dec/19 16:22

Description

Spotless has certain drawbacks:
1) It is not able to verify license headers for non-Java files. For instance, it skips `package-info.java`, it skips `*.kts` and so on
2) Its error messages are too verbose. Sometimes it prints the full stacktrace when just one line was enough: "file X line Y column Z has error: ..."
3) It uses unsafe Gradle APIs, so it will be incompatible with Gradle 7.0

I suggest to replace it with https://github.com/autostyle/autostyle

Note: I tried to contact Spotless authors, and their way to manage code makes it very hard to co-operate (

Issue Links

• links to: GitHub Pull Request #118
• links to: GitHub Pull Request #1682