[CALCITE-3606] batch insert failed

• Type: Wish
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.21.0
• Fix Version/s: 1.22.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Danny Chen
• Reporter: Ran Cao
• Created: 18/Dec/19 04:05
• Updated: 06/Mar/20 04:36
• Resolved: 06/Jan/20 11:43

Description

when I try to execute sql like (insert into example_table (column1,column2) values (value1,value2),(value1,value2)), it will failed with error message like this: column "EXPR$0" of relation "example_table" does not exist. I find the reason is that when converting SqlNode(insert sql) to RelNode(TableModify), one of the steps is to change the column that stored in RelDataType from the fake column name (like "EXPR$0") to the real column name (like "id"). But when the values part in sql is more than one , the step above-mentioned will skip because the RelNode is instance of  LogicalUnion instead of Project, the code refered to org.apache.calcite.tools.RelBuilder line 1461:

if (input instanceof Project && fieldNames != null)

{     // change the column name }

 

Issue Links

• links to: GitHub Pull Request #1695