[CALCITE-3571] RelBuilder#shouldMergeProject throws an exception for JOIN with complex conditions

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.21.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Kirill Kozlov
• Created: 06/Dec/19 00:58
• Updated: 26/Dec/19 23:02
• Resolved: 26/Dec/19 23:01

Description

Table `tblA` schema: 

field_name	field_type
id	VARBINARY
fA1	VARCHAR

 Table `tblB` schema:

field_name	field_type
id	VARCHAR
fB1	VARCHAR

For the following query:

WITH query as (select SELECT id, fA1, fA1 AS fA1_2 FROM tblA)
SELECT fA1, fB1, fA1_2
FROM query
JOIN tblB ON (TO_HEX(query.id) = tblB.id)

TO_HEX is used as an example, but it can be any other expression; for instance `cast(query.id as Integer)`.

Out of bound exception is thrown in SqlToRelConverter. 

 

Before joins are created left and right paths are parsed first. For the 1st query above they are as follows:

Left:
LogicalProject with RecordType(VARBINARY id, VARCHAR fA1, VARCHAR fA1_2)
  LogicalTableScan with RecordType(VARBINARY id, VARCHAR fA1)

Right:
LogicalTableScan with RecordType(VARCHAR id, VARCHAR fB1)

As they are processed - they are registered as leaves (added to the Array).

 

When Join node is being created it knows what the `condition expressions` is:

=(TO_HEX($0), $3)

Since TO_HEX is not computed anywhere - it modifies the left input to be as follows (via RelOptUtil#pushDownJoinConditions) because RelBuilder#shouldMergeProject always return true. 

LogicalProject with RecordType(VARBINARY id, VARCHAR fA1, VARCHAR fA1_2, VARCHAR $f3)

where `VARCHAR $f3` is a result of TO_HEX. Note that the list of leaves is not updated.

https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java#L2571

 

Finally, when identifier "query.fA1_2" is being converted (via SqlToRelConverter#convertIdentifier) for the top-most node

top-most node:
LogicalProject with RecordType(VARBINARY id, VARCHAR fA1, VARCHAR fA1_2, VARCHAR id0, VARCHAR fB1)
  LogicalJoin with RecordType(VARBINARY id, VARCHAR fA1, VARCHAR fA1_2, VARCHAR $f3, VARCHAR id0, VARCHAR fB1)
    LogicalProject with RecordType(VARBINARY id, VARCHAR fA1, VARCHAR fA1_2, VARCHAR $f3)
      LogicalTableScan with RecordType(VARBINARY id, VARCHAR fA1)
    LogicalTableScan with RecordType(VARCHAR id, VARCHAR fB1)

Blackboard perform a lookup (via SqlToRelConverter#lookupExp), in process of which LookupContext is created.

In a constructor, LookupContext performs flatten, which recursively traverses  tree of nodes (from above codeblock) and checks the leaves to see if they contain such expression. When it does get to the modified left input of a join it does not get a match on it and continues further down to a TableScan.

When it finally flattens the result, TableScan's RecordType knows nothing about a duplicated field `fA1_2`, causing an error above.

 

I think a viable solution would be to modify Join creation to register a resulting join inputs as leaves (when they are modified). Alternative approach would be to not merge Projects when join needs to modify an input.

Issue Links

• blocks: BEAM-8896 WITH query AS + SELECT query JOIN other throws invalid type
• is related to: CALCITE-3575 IndexOutOfBoundsException when converting sql to rel
• links to: GitHub Pull Request #1637