[CALCITE-3563] When resolving method call in calcite runtime, add type check and match mechanism for input arguments

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.22.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Feng Zhu
• Reporter: Feng Zhu
• Created: 04/Dec/19 08:08
• Updated: 28/May/21 10:09
• Resolved: 31/Dec/19 08:11

Description

Sub-task targets on following issue.

 

(1)Validation phase allows a wide range of operand types, but the runtime implementation does not cover all cases.
For example, SqlFunction(MOD) adopts OperandTypes.EXACT_NUMERIC_EXACT_NUMERIC.

@Test public void test0() {
 final String sql = "SELECT mod(12.5, cast(1 as bigint))";
 CalciteAssert.that()
 .query(sql)
 .returns("EXPR$0=0.5\n");
 }

We will get:

java.lang.RuntimeException: while resolving method 'mod[class java.math.BigDecimal, long]' in class class org.apache.calcite.runtime.SqlFunctions
 at org.apache.calcite.linq4j.tree.Types.lookupMethod(Types.java:323)
 at org.apache.calcite.linq4j.tree.Expressions.call(Expressions.java:445)
 at org.apache.calcite.adapter.enumerable.RexImpTable$MethodNameImplementor.implement(RexImpTable.java:2253)
 at org.apache.calcite.adapter.enumerable.RexImpTable.implementCall(RexImpTable.java:1195)

 

Issue Links

• links to: GitHub Pull Request #1675