[CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.22.0
• Labels: pull-request-available
• Assignee: Igor Guzenko
• Reporter: Igor Guzenko
• Created: 20/Nov/19 19:52
• Updated: 06/Mar/20 07:33
• Resolved: 24/Dec/19 14:19

Description

Sample case to reproduce in

RexProgramTest.simplifyOrTerms

:

    // (a=1 or a=2 or (arr[1]>4 and arr[1]<3 and a=3)) => a=1 or a=2
    final RelDataType intArrayType = typeFactory.createArrayType(intType, -1);
    final RexInputRef ref0 = rexBuilder.makeInputRef(intType, 0);
    final RexInputRef ref3 = rexBuilder.makeInputRef(intArrayType, 3);
    final RexCall itm1 = (RexCall) rexBuilder.makeCall(intType, SqlStdOperatorTable.ITEM,
        ImmutableList.of(ref3, literal1));
    simplify = this.simplify.withParanoid(false);
    checkSimplifyFilter(
        or(
            eq(ref0, literal1),
            eq(ref0, literal2),
            and(
                gt(itm1, literal4),
                lt(itm1, literal3),
                eq(ref0, literal3)
            )
        ),
        "OR(=($0, 1), =($0, 2))"
    );
    simplify = simplify.withParanoid(true);

Issue Links

• links to: GitHub Pull Request #1610