Details
-
Improvement
-
Status: Closed
-
Major
-
Resolution: Fixed
-
None
Description
This is a regression caused by the refactoring in 1.20.0.
When terms has only 1 element, it will throw an exception. We discovered the issue when trying to upgrade Calcite.
public static RexNode simplifyOrs(RexBuilder rexBuilder, List<RexNode> terms) { return new RexSimplify(rexBuilder, RelOptPredicateList.EMPTY, EXECUTOR) .simplifyUnknownAs(rexBuilder.makeCall(SqlStdOperatorTable.OR, terms), RexUnknownAs.UNKNOWN); }
We can't assume the terms always has more than 1 element. Although this method is deprecated, I think we need to correct the regression. Maybe we don't need a test case, given it is a deprecated method.
Attachments
Issue Links
- links to