[CALCITE-3491] VolcanoPlanner.completeConversion() is bypassed by "if (true)"

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.22.0
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Xiening Dai
• Created: 11/Nov/19 18:39
• Updated: 06/Mar/20 04:34
• Resolved: 15/Nov/19 19:15

Description

Not very clear about why we need VolcanoPlanner.completeConversion(). It's currently bypassed as below[1] -

if (true)

{ return rel; }

If the method is not needed, we should just remove it.

[1] https://github.com/apache/calcite/blob/f90e5d7b48848191c1a70e6c0f78eece93433806/core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java#L1096

Issue Links

• links to: GitHub Pull Request #1586