Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-3491

VolcanoPlanner.completeConversion() is bypassed by "if (true)"

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.22.0
    • Component/s: None

      Description

      Not very clear about why we need VolcanoPlanner.completeConversion(). It's currently bypassed as below[1] -

      if (true)

      { return rel; }

      If the method is not needed, we should just remove it.

      [1] https://github.com/apache/calcite/blob/f90e5d7b48848191c1a70e6c0f78eece93433806/core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java#L1096

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              xndai Xiening Dai

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h
                1h

                  Issue deployment