[CALCITE-3486] In JDBC adapter, when generating ROW value expression, generates the ROW keyword only if the dialect allows it

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.21.0
• Fix Version/s: 1.22.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Danny Chen
• Reporter: quxiucheng
• Created: 08/Nov/19 16:35
• Updated: 28/May/21 10:09
• Resolved: 17/Nov/19 05:38

Description

when we use mysql dialect unparse sql,the Mysql dialect does not have a ROW keyword,

but the ROW keyword does exist in SQL

SQL

insert into emps values (1,'Fredkin')

SqlNode.toString(MysqlSqlDialect.DEFAULT)

insert into emps values ROW(1,'Fredkin')

This syntax is problematic in mysql

 

Issue Links

• links to: GitHub Pull Request #1568