[CALCITE-3475] BigQuery SQL dialect unparseCall override broken for UNION ALL

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.22.0
• Assignee: Julian Hyde
• Reporter: Steven Talbot
• Created: 04/Nov/19 17:42
• Updated: 06/Mar/20 04:34
• Resolved: 05/Nov/19 01:24

Description

The break on line https://github.com/apache/calcite/blob/ff43dcb95caa251e5fc8120980fc70c8fea8ac40/core/src/main/java/org/apache/calcite/sql/dialect/BigQuerySqlDialect.java#L134 should be inside the if. Otherwise, UNION ALL does not trigger the if, hits the `break`, and then nothing is unparsed at all!

 

From looking at the code, INTERSECT and EXCEPT would seem to have the same problem, except per BQ syntax specification at https://cloud.google.com/bigquery/docs/reference/standard-sql/query-syntax#set-operators, the "ALL" is not supported with either of those, so it may not matter (but the code may want to explicitly blow up, saying that those aren't supported?)

Issue Links

• is related to: CALCITE-2623 Add specific translation for POSITION, MOD and set operators in BigQuery and Hive SQL dialects
• links to: Github PR