Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-3475

BigQuery SQL dialect unparseCall override broken for UNION ALL

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.22.0
    • Component/s: None
    • Labels:
      None

      Description

      The break on line https://github.com/apache/calcite/blob/ff43dcb95caa251e5fc8120980fc70c8fea8ac40/core/src/main/java/org/apache/calcite/sql/dialect/BigQuerySqlDialect.java#L134 should be inside the if. Otherwise, UNION ALL does not trigger the if, hits the `break`, and then nothing is unparsed at all!

       

      From looking at the code, INTERSECT and EXCEPT would seem to have the same problem, except per BQ syntax specification at https://cloud.google.com/bigquery/docs/reference/standard-sql/query-syntax#set-operators, the "ALL" is not supported with either of those, so it may not matter (but the code may want to explicitly blow up, saying that those aren't supported?)

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                julianhyde Julian Hyde
                Reporter:
                swtalbot Steven Talbot
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: