[CALCITE-3474] SqlSimpleParser toke.s equals NullPointerException

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.21.0
• Fix Version/s: 1.22.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: quxiucheng
• Created: 04/Nov/19 08:42
• Updated: 06/Mar/20 04:34
• Resolved: 09/Nov/19 19:12

Description

 

 

SQL：

 

select ^ from (select * from sales.emp ) a

use SqlSimpleParser parse sql

Exception:

 

 

 

java.lang.NullPointerExceptionjava.lang.NullPointerException at org.apache.calcite.sql.advise.SqlSimpleParser$Query.contains(SqlSimpleParser.java:818) at org.apache.calcite.sql.advise.SqlSimpleParser$Query.simplify(SqlSimpleParser.java:548) at org.apache.calcite.sql.advise.SqlSimpleParser$Query.simplifyList(SqlSimpleParser.java:508) at org.apache.calcite.sql.advise.SqlSimpleParser.simplifySql(SqlSimpleParser.java:171) at org.apache.calcite.sql.advise.SqlSimpleParser.simplifySql(SqlSimpleParser.java:141) at org.apache.calcite.sql.advise.SqlAdvisor.simplifySql(SqlAdvisor.java:556) at org.apache.calcite.sql.advise.SqlAdvisor.getCompletionHints0(SqlAdvisor.java:222) at org.apache.calcite.sql.advise.SqlAdvisor.getCompletionHints(SqlAdvisor.java:192)

 

 

cause:

SqlSimpleParser Token.s

s is null

private boolean contains(String hintToken) {
  for (Token token : tokenList) {
    switch (token.type) {
    case ID:
      // exception
      if (token.s.equals(hintToken)) {
        return true;
      }
      break;
    case QUERY:
      if (((Query) token).contains(hintToken)) {
        return true;
      }
      break;
    }
  }
  return false;
}

 

 

 

 

Issue Links

• links to: GitHub Pull Request #1558