[CALCITE-3389] Test can fail if HashSet iterates in a different order

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.22.0
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: contextshuffling
• Created: 05/Oct/19 20:40
• Updated: 06/Mar/20 04:35
• Resolved: 07/Oct/19 18:00

Description

For test `testTenElementsSetLiteral`(https://github.com/apache/calcite/blob/78c2a007b5b597f673323b80dde21c23d31f23ea/linq4j/src/test/java/org/apache/calcite/linq4j/test/ExpressionTest.java#L1538)

It relies on the iteration order of a HashSet. However, HashSet does not guarantee any specific order of entries. Tests can fail if the iteration order changes.

Please let me know if you want to discuss the changes more.

Issue Links

• links to: GitHub Pull Request #1487