[CALCITE-3365] Don't require use of JdbcSchema in QuerySqlStatisticProvider

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.22.0
• Labels: pull-request-available
• Assignee: Julian Hyde
• Reporter: Lindsey Meyer
• Created: 20/Sep/19 18:23
• Updated: 06/Mar/20 04:36
• Resolved: 24/Sep/19 19:13

Description

We're trying to pass in schema data manually to process queries for BigQuery, but that causes problems in the QuerySqlStatisticProvider because it requires a JdbcSchema in order to get the dialect and dataSource, as well as using a Jdbc Builder.

I propose refactoring QuerySqlStatisticProvider to grab the dialect and dataSource using unwrap on the schema instead, so that any schema that implements unwrap methods for these types will work with QuerySqlStatisticProvider. As well as using a generic RelBuilder, instead of a JDBC_BUILDER.

cc julianhyde since we have been discussing this

I've opened a PR at https://github.com/apache/calcite/pull/1467

Issue Links

• links to: GitHub Pull Request #1467