[CALCITE-3327] Simplify SqlValidatorTest by replacing 'boolean typeCoercion' parameter with fluent method 'Sql.withTypeCoercion(boolean)'

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.22.0
• Assignee: Julian Hyde
• Reporter: Julian Hyde
• Created: 06/Sep/19 23:46
• Updated: 06/Mar/20 04:34
• Resolved: 23/Sep/19 22:42

Description

Simplify SqlValidatorTest by replacing boolean typeCoercion parameter with fluent method withTypeCoercion(boolean) in class SqlValidatorTestCase.Sql.

The problem with the boolean typeCoercion parameter is that it doesn't compose with all of the other flags we might want to pass - are we testing a query or an expression?, is it supposed to pass or fail?, does it contain window functions? - and therefore we have to add it in a combinatorial number of places.

Fluent interfaces are preferred over "test methods" like checkExpFails for big tests like SqlValidatorTest.

I'm developing a fix, and I'll post the branch URL shortly.

Issue Links

• is related to: CALCITE-2302 Implicit type cast support
• links to: Dev branch