[CALCITE-3324] Infinite loop when calling DDL from remote Avatica driver to LocalService wrapping CalciteMetaImpl

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.20.0
• Fix Version/s: avatica-1.16.0, 1.23.0
• Component/s: avatica, core
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Robert Yokota
• Created: 04/Sep/19 22:42
• Updated: 24/May/20 12:00
• Resolved: 14/Apr/20 13:44

Description

I encountered an infinite loop when submitting DDL from a remote Avatica driver (using sqlline) against a LocalService wrapping CalciteMetaImpl.

I was able to debug the issue and verified a fix.

The problem was that in CalciteMetaImpl.prepareAndExecute, the updateCount is not being passed to the MetaResultSet constructor.  Instead, the updateCount is always set to -1.  This incorrectly instructs the remote Avatica driver to fetch results when there aren't any, which causes it to loop.

By fixing the CalciteMetaImpl.prepareAndExecute method to set the updateCount in MetaResultSet, I was able to fix the infinite loop.

Issue Links

• links to: GitHub Pull Request #111
• links to: GitHub Pull Request #1441