[CALCITE-3318] Preserving CAST of VARCHAR operand in binary comparison for BigQuery

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.20.0
• Fix Version/s: 1.22.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Danny Chen
• Reporter: Soma Mondal
• Created: 03/Sep/19 09:51
• Updated: 06/Mar/20 04:36
• Resolved: 18/Oct/19 09:56

Description

We have a REL which has this information
select * from employee where employee_id = cast('12' as float);

but Calcite removes the CAST from the STRING literal('12' in our case). 
select * from employee where employee_id = '12';

There are dialects which needs explicit casting in the above case and we need to maintain the CAST in our dialect.

Calcite removes the cast in SqlImplementor's stripCastFromString() method.

I'm thinking of having the dialect intercept this and decide whether or not to remove the cast.

 

I have created a PR https://github.com/apache/calcite/pull/1437

Issue Links

• links to: GitHub Pull Request #1437